Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_parallelism session property to BigQuery #22273

Closed
wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 5, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 5, 2024
@github-actions github-actions bot added the bigquery BigQuery connector label Jun 5, 2024
@@ -32,6 +35,7 @@ public final class BigQuerySessionProperties
private static final String VIEW_MATERIALIZATION_WITH_FILTER = "view_materialization_with_filter";
private static final String QUERY_RESULTS_CACHE_ENABLED = "query_results_cache_enabled";
private static final String CREATE_DISPOSITION_TYPE = "create_disposition_type";
private static final String READ_PARALLELISM = "read_parallelism";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that all the session properties are missing from bigquery.md - i'm guessing that the documentation can be done in a follow-up. Pls create a follow-up docs ticket for this.

@wendigo wendigo requested a review from ebyhr June 5, 2024 10:25
@findepi
Copy link
Member

findepi commented Jun 5, 2024

How would a user know how to set this property? what value should they pick?

cc @mayankvadariya @dekimir

@findepi
Copy link
Member

findepi commented Jun 5, 2024

see #22279

@ebyhr
Copy link
Member

ebyhr commented Jun 11, 2024

Superseded by #22279

@ebyhr ebyhr closed this Jun 11, 2024
@ebyhr ebyhr deleted the serafin/bq-session-parallelism branch June 11, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery BigQuery connector cla-signed
Development

Successfully merging this pull request may close these issues.

4 participants