Fix OpenX JSON decoding of top level JSON array #23163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenX JSON supports decoding JSON lines containing a JSON array, as opposed to a JSON object. In this case the values are mapped to columns using the ordinal position instead of mapping by field name. The decoder was not using the Column ordinal and instead was just using the position in the output list, which resulted in data appearing in the wrong output column.
pettyjamesm
approved these changes
Sep 4, 2024
rmarrowstone
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenX JSON supports decoding JSON lines containing a JSON array, as opposed to a JSON object. In this case the values are mapped to columns using the ordinal position instead of mapping by field name. The decoder was not using the Column ordinal and instead was just using the position in the output list, which resulted in data appearing in the wrong output column.
This bug has been present since the first version of the native OpenX JSON decoder.
Fixes #23120
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: