Just committed my changes... #6
Conversation
Files Page: -double click on phone file (both panes) opens file in PC with the associated program for that extension with option to edit the file and save it back to phone; -added "Properties" in phone files/folders right click context menu with permissions changing capabilities; -switching left pane between PC/phone files now remembers last folder view for both; -left paths combo box now works for phone files too when switching left pane to phone files; -some bugs fixes; Apps Page: -major speedup displaying apps after the initial first run when apps info is collected; -fixed all functions, now all buttons and actions works as they should; -now you can backup and restore apps and data to any folder on /sdcard or PC, set backup folder location in Settings first; -option added to Backups context menu to add app/data if missing from existing previous backup; Recovery Page replaced with new Advanced Menu Page that works with CWM Recovery. What can be done: -run fix_permissions in Android OS mode, not in recovery mode. As you may know fix_permissions in CWM recovery is broken; -Fix/Undo Fix Market Cache Download; -Flash new Recovery; -Mount/Unmount any partition in recovery mode, Remount /system with read-write/read-only access in Android OS mode; -Repartitioning SD Card with /sd-ext partition (your choice of size and type) with option to backup /sdcard content before, and restoring it after the operation; -Wipe data/factory reset, cache, dalvik-cache, battery stats (your choice) in recovery mode; -Install zip of your choice from /sdcard; -Backup ROM to any folder on /sdcard or to default CWM location with option for Backup md5 sum validation after phone reboots back to Android OS, ensures proper backup is done; -Restore nandroid Backup with option to choose which partitions to restore(select all for full restore) and preliminary md5 sum validation for double safety; -One click Update ROM function which wipes cache and dalvik-cache before flashing. If Link2SD is detected on your phone you have an option to automatically copy its sd-ext mount script from current ROM to the new updated ROM saving you one reboot. Link2SD will not even know you updated the ROM; -One click ROM Flash with full wipe and options to install zips before/after(or both) the flash - this procedure reboots phone to Recovery, wipes dalvik-cache, formats /boot, /system, /data and /cache partitions, installs zip before(if selected), installs the new ROM, installs zip after(if selected) and reboots back to Android OS. Detailed information in Status Window is displayed for all operations taking place in real time. After phone reboots back to Android OS, the last CWM recovery log is displayed so you can spot any errors occurred during the last operation. -Shell Page is replaced with Command Prompt "adb shell" window; -And probably something else I forgot about; All bugs fixed(I believe). I want to thank and give credits to the guys (couldn't find their names) created some of the tools I'm using to make the new features works.
|
Thank you very much for your work. I will review it an will merge. 2012/3/22 nijel8 < |
ghost
assigned 
| // this->fontShell = tmp; | ||
| // this->ui->editFontShell->setText(this->fontShell.family()); | ||
| // this->ui->editFontShell->setFont(this->fontShell); | ||
| // } | ||
| } |
There was a problem hiding this comment.
Why you are removing font dialog?
There was a problem hiding this comment.
I kind of didn't like the shell widget. I tried to modify it somehow, tried
for instance to implement right click menu with "paste" and "copy" but I
couldn't get it to work the way I wanted so I replaced it with windows
command prompt shell. And SettingsWidget::chooseFontTables() dialog became
useless.
Sorry, this is my first attempt in programing. I'm learning as I go.
-----Original Message-----
From: triochi
Sent: Thursday, March 22, 2012 5:40 AM
To: nijel8
Subject: Re: [QtAdb] Just committed my changes... (#6)
- tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
- if (ok)
- {
this->fontShell = tmp;this->ui->editFontShell->setText(this->fontShell.family());this->ui->editFontShell->setFont(this->fontShell);- }
+// bool ok;
+// QFont tmp;
+// tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
+// if (ok)
+// {
+// this->fontShell = tmp;
+// this->ui->editFontShell->setText(this->fontShell.family());
+// this->ui->editFontShell->setFont(this->fontShell);
+// }
}
Why you are removing font dialog?
Reply to this email directly or view it on GitHub:
https://github.com/triochi/QtAdb/pull/6/files#r589927
There was a problem hiding this comment.
I have improved the shell widget a little in the work branch. Now the adb
shell is reinvoked if the connection is lost. And there is a short help
message on the first start. I find the improved shell useful. Yes paste on
right click or right click menu will be even better. Yet QtAdb should work
OK on linux and Mac too. So if you patch part of code, think of that too.
Yes, I'm Bulgarian.
Regards
triochi
2012/3/22 nijel8 <
reply@reply.github.com
- tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
- if (ok)
- {
this->fontShell = tmp;this->ui->editFontShell->setText(this->fontShell.family());this->ui->editFontShell->setFont(this->fontShell);- }
+// bool ok;
+// QFont tmp;
+// tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
+// if (ok)
+// {
+// this->fontShell = tmp;
+// this->ui->editFontShell->setText(this->fontShell.family());
+// this->ui->editFontShell->setFont(this->fontShell);
+// }
}I kind of didn't like the shell widget. I tried to modify it somehow, tried
for instance to implement right click menu with "paste" and "copy" but I
couldn't get it to work the way I wanted so I replaced it with windows
command prompt shell. And SettingsWidget::chooseFontTables() dialog became
useless.
Sorry, this is my first attempt in programing. I'm learning as I go.BTW are you bulgarian?
Nick
-----Original Message-----
From: triochi
Sent: Thursday, March 22, 2012 5:40 AM
To: nijel8
Subject: Re: [QtAdb] Just committed my changes... (#6)
- tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
- if (ok)
- {
this->fontShell = tmp;this->ui->editFontShell->setText(this->fontShell.family());this->ui->editFontShell->setFont(this->fontShell);- }
+// bool ok;
+// QFont tmp;
+// tmp = QFontDialog::getFont(&ok, QFont(this->fontShell), this);
+// if (ok)
+// {
+// this->fontShell = tmp;
+// this->ui->editFontShell->setText(this->fontShell.family());
+// this->ui->editFontShell->setFont(this->fontShell);
+// }
}Why you are removing font dialog?
Reply to this email directly or view it on GitHub:
https://github.com/triochi/QtAdb/pull/6/files#r589927
Reply to this email directly or view it on GitHub:
https://github.com/triochi/QtAdb/pull/6/files#r590158
|
You are right, I didn't think about mac/linux users. Actually I didn't think about any other users.When I started playing with the code I just wanted to make it work and look the way I wanted it. Later on I decided to submit my code to you guys and apparently my "selfish" coding is becoming a problem of course. I'm bulgarian to btw. |
Regards 2012/3/22 nijel8 <
|
|
This patch should be reworked. nijel8 will add only bug fixes and his new features. |
What is different from current official build 0.8.1:
Files Page:
-double click on phone file (both panes) opens file in PC with the associated program for that extension with option to edit the file and save it back to phone;
-added "Properties" in phone files/folders right click context menu with permissions changing capabilities;
-switching left pane between PC/phone files now remembers last folder view for both;
-left paths combo box now works for phone files too when switching left pane to phone files;
-some bugs fixes;
Apps Page:
-major speedup displaying apps after the initial first run when apps info is collected;
-fixed all functions, now all buttons and actions works as they should;
-now you can backup and restore apps and data to any folder on /sdcard or PC, set backup folder location in Settings first;
-option added to Backups context menu to add app/data if missing from existing previous backup;
Recovery Page replaced with new Advanced Menu Page that works with CWM Recovery. What can be done:
-run fix_permissions in Android OS mode, not in recovery mode. As you may know fix_permissions in CWM recovery is broken;
-Fix/Undo Fix Market Cache Download;
-Flash new Recovery;
-Mount/Unmount any partition in recovery mode, Remount /system with read-write/read-only access in Android OS mode;
-Repartitioning SD Card with /sd-ext partition (your choice of size and type) with option to backup /sdcard content before, and restoring it after the operation;
-Wipe data/factory reset, cache, dalvik-cache, battery stats (your choice) in recovery mode;
-Install zip of your choice from /sdcard;
-Backup ROM to any folder on /sdcard or to default CWM location with option for Backup md5 sum validation after phone reboots back to Android OS, ensures proper backup is done;
-Restore nandroid Backup with option to choose which partitions to restore(select all for full restore) and preliminary md5 sum validation for double safety;
-One click Update ROM function which wipes cache and dalvik-cache before flashing. If Link2SD is detected on your phone you have an option to automatically copy its sd-ext mount script from current ROM to the new updated ROM saving you one reboot. Link2SD will not even know you updated the ROM;
-One click ROM Flash with full wipe and options to install zips before/after(or both) the flash - this procedure reboots phone to Recovery, wipes dalvik-cache, formats /boot, /system, /data and /cache partitions, installs zip before(if selected), installs the new ROM, installs zip after(if selected) and reboots back to Android OS.
Detailed information in Status Window is displayed for all operations taking place in real time. After phone reboots back to Android OS, the last CWM recovery log is displayed so you can spot any errors occurred during the last operation.
-Shell Page is replaced with Command Prompt "adb shell" window;
-And probably something else I forgot about;
All bugs fixed(I believe).
I want to thank and give credits to the guys (couldn't find their names) created some of the tools I'm using to make the new features works.
If you guys know a good way to detect what recovery is installed on the phone within Android OS, then we can switch appropriate widget for that recovery. Right now the original RecoveryWidget does not work with CWM based Recoveries. Even it can harm phones running CWM recovery. Thats why I replaced it with new CwmWidget. Lets think how to incorporate both without messing up phones.