Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group 1: FORMS Registration Form #24

Closed
laceysanderson opened this issue Jan 6, 2020 · 11 comments
Closed

Group 1: FORMS Registration Form #24

laceysanderson opened this issue Jan 6, 2020 · 11 comments

Comments

@laceysanderson
Copy link
Member

In Tripal 3 we have a registration form for administrators to register with tripal.info. This is important for ongoing funding and presentations. This issue is to upgrade the Site Registration form shown below to Drupal 8:
Firefox_Screenshot_2020-01-06T18-17-08 386Z

Resources:

@risharde
Copy link
Contributor

risharde commented Jan 9, 2020

I'm trying my very best to get this converted @laceysanderson

@risharde
Copy link
Contributor

risharde commented Jan 9, 2020

#30 @laceysanderson

My apologies, this is as much as I can do at the moment due to my inexperience with D8, the PR shows what still needs to be done like form_state and multiple fund sources button

@laceysanderson
Copy link
Member Author

Awesome! Thanks for getting us started :-) I'll take a look at it right away

@laceysanderson
Copy link
Member Author

I've committed your PR (#30) into d8-tv4-issue24-registrationform branch to provide a great base for future work on this issue. Thank you!

@katherynbuble
Copy link
Contributor

Planning to work on this tomorrow (Jan 10, 2020).

@risharde
Copy link
Contributor

Thank you @katherynbuble ! Really appreciate you continuing this!

@par12005
Copy link
Contributor

@laceysanderson, I just submitted a PR for my attempt at implementing the submission/validation functions for the registration form.

Also, I'm new to both Tripal 4 and Drupal 8, so if my code has any issues related to the differences between T3/4 or D7/8, please let me know, I would love to learn more about both!

@par12005
Copy link
Contributor

par12005 commented Apr 6, 2020

Thanks @laceysanderson for merging my PR! Do you think the branch d8-tv4-issue24-registrationform is ready to be merged into 8.x-4.x?

@laceysanderson
Copy link
Member Author

I guess we could. I was going to wait until tripal/tripal#1329 was fixed but that could be done after as well. It is completely functional after all 😃 👍

@laceysanderson
Copy link
Member Author

Thank you everyone for your contributions!!! The registration form has been merged back into 8.x-4.x and works! The only think left to be completed is tripal/tripal#1329 which will be carried on in that issue.

@par12005
Copy link
Contributor

par12005 commented Apr 6, 2020

Thanks @laceysanderson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants