Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group 1: Installation File #25

Closed
laceysanderson opened this issue Jan 6, 2020 · 2 comments
Closed

Group 1: Installation File #25

laceysanderson opened this issue Jan 6, 2020 · 2 comments

Comments

@laceysanderson
Copy link
Member

This issue is for upgrading the content of the tripal/tripal.install file. Really the only thing to be updated is hook_schema and not many changes were made in Drupal 8.

Notes:

  • We are not worrying about the upgrade process as this point.
  • We are keeping the tripal_variables infrastructure but no longer using them for core thus the tripal_add_variables function does not need to be upgraded.
  • Drupal 8 no longer supports hook_enable and at this point we don't need to worry about the drop/rename table dance you see going on there -skip tripal_enable when upgrading.
  • The schema should be the only part that needs to be upgraded. Again don't do the table rename part. Also skip tripal_vocab, tripal_term, tripal_entity and tripal_bundle as these are already managed by the entity api.
  • no need to keep the tripal_update_### functions.

Resources:

@almasaeed2010
Copy link
Contributor

PR submitted #29

@laceysanderson
Copy link
Member Author

PR Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants