Filtering sub elements in Tripal Entity Views. #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spficklin
changed the title
spficklin
added
bug - confirmed
|
tripal/tripal_analysis_interpro#31 (comment) is a functional approval, so with that i will merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Issue: tripal/tripal_analysis_interpro#31
Description
An issue was reported on the Tripal Analysis InterPro project by @martacds. The problem is that when trying to add a filter to a view it's not working. The example is when trying to add a filter for annotations (CV terms)_ on a feature page (i.e. for InterPro terms). Adding the filter works just fine, but it doesn't actually do any filtering.
The problem is actually much bigger than just filtering on annotations (cv terms). It occurs for any field that has sub elements. For example, adding a 'Genus' or 'Species' filter also has no effect as those are sub elements of the
obi__organismfield.Testing?
To test this before pulling the branch, try testing adding a 'Genus' or 'Species' filter to any View that searches a feature. It will not work. then pull the branch and rerun the View. The 'Genus' or 'Species' filter should now work.
You can also test with any other field that has sub elements (e.g. relationships, cv terms).