Lobby config: direct 2.5 users to 'prod.triplea-game.org' #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the 2.5 game engine and below reads 'servers.yml'. This update directs those game clients to 'prod.triplea-game.org'. We have NGINX running on that URL which will in turn redirect the game client to an appropriate lobby server (NGINX going forward will control which game client versions connect to which lobby).
|
There are some additional 2.6 bots coming online (I turned them off in the 2.5 lobby).
After merge, we can essentially turn off the 2.5 lobby entirely (keeping in mind we will be disconnecting any users and preventing them from rejoining bot-games. Perhaps best down when the lobby is at 'low-tide' in terms of activity). |
Codecov Report
@@ Coverage Diff @@
## master #11194 +/- ##
=========================================
Coverage 27.22% 27.22%
Complexity 8250 8250
=========================================
Files 1217 1217
Lines 78077 78077
Branches 10615 10615
=========================================
+ Hits 21253 21255 +2
+ Misses 54856 54854 -2
Partials 1968 1968
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the 2.5 game engine and below reads 'servers.yml'. This update directs those game clients to 'prod.triplea-game.org'. We have NGINX running on that URL which will in turn redirect the game client to an appropriate lobby server (NGINX going forward will control which game client versions connect to which lobby).
Change Summary & Additional Notes
Merging this would have immediate effect for any 2.5 users logging into the lobby.
Release Note