Don't reset purchase selection on purchase error. #11818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if you tried to buy too many of a unit. Previously, your full purchase selection will be cleared. Now, it will just bring you back to the purchase screen after showing error, keeping the previous selections.
asvitkine
added a commit
to asvitkine/triplea-1
that referenced
this pull request
Jun 26, 2024
The fix in triplea-game#11818 regressed with the changes for saving purchases in saved games. This restores it. Also fixes the error message to not display a negative max limit.
asvitkine
added a commit
that referenced
this pull request
Jun 26, 2024
The fix in #11818 regressed with the changes for saving purchases in saved games. This restores it. Also fixes the error message to not display a negative max limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
For example, if you tried to buy too many of a unit. Previously, your full purchase selection will be cleared. Now, it will just bring you back to the purchase screen after showing error, keeping the previous selections.
Manually tested on 1941 Global Command Decision when trying to buy too many Army HQs.
Release Note
FIX|Your purchase selections will no longer be reset when trying to select an invalid purchase (e.g. too many units of a type). You'll be brought back to the purchase screen to correct the error.