Ai fix planes without carrier capacity purchase bug #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ron-murhammer
commented
May 25, 2017
|
|
||
| ProLogger.trace("Select purchase option for " + type); | ||
| double totalEfficiency = 0; | ||
| for (final Double efficiency : purchaseEfficiencies.values()) { | ||
| totalEfficiency += efficiency; | ||
| } | ||
| if (totalEfficiency == 0) { | ||
| return Optional.empty(); | ||
| } |
There was a problem hiding this comment.
This is essentially the core of the change. Everything else is just updating all the references and clean up.
ssoloff
reviewed
May 25, 2017
There was a problem hiding this comment.
@ron-murhammer, I know pretty much nothing about the AI code, so I simply sanity checked this and didn't see anything that looked problematic. Existing unit tests would have been nice, but ProPurchaseAI looks like a beast. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this reported bug: https://forums.triplea-game.org/topic/73/iron-war-official-thread/85
For AI sea zones purchases, if it can't afford any sea units but can afford air units, it will buy air units even if there isn't carrier space. It actually realizes there isn't enough carrier room but there is a bug that even though all air units have a 0% chance of being purchased it still selects one of them randomly! Essentially, this is just a rare edge case that has to do with not handling when only air units are available to purchase based on resources in a SZ and none of them have carrier space. This pretty much never happens on 99% of maps since they have cheap sea units like subs or destroyers that would always be available.