Use dynamic heap size for installers #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot use a fixed heap size of 2 GiB because it will fail to be allocated on 32-bit OSes. Instead, we employ the following algorithm: * Initially use half of available memory * If a 32-bit JVM, use no more than 1 GiB * If a 64-bit JVM, use no more than 2 GiB
Codecov Report
@@ Coverage Diff @@
## master #4336 +/- ##
============================================
+ Coverage 22.61% 22.62% +<.01%
- Complexity 6099 6101 +2
============================================
Files 870 870
Lines 71159 71159
Branches 11362 11362
============================================
+ Hits 16096 16099 +3
+ Misses 53023 53022 -1
+ Partials 2040 2038 -2
Continue to review full report at Codecov.
|
ron-murhammer
approved these changes
Nov 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4255 on
master. This PR is simply a cherry-pick of #4328.Changes
See #4328.
Manual Testing Performed
Locally built the Windows x86 installer and ran it. Verified the resulting installation could be started.