Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pauses from RandomStartDelegate #4774

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

ron-murhammer
Copy link
Member

Overview

  • Remove pauses for RandomStartDelegate as I can't see any reason that they are needed and for large maps make the initial set up very slow

@codecov-io
Copy link

Codecov Report

Merging #4774 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4774      +/-   ##
===========================================
+ Coverage      23.1%   23.1%   +<.01%     
- Complexity     6146    6177      +31     
===========================================
  Files           867     895      +28     
  Lines         70007   70252     +245     
  Branches      11211   11240      +29     
===========================================
+ Hits          16175   16235      +60     
- Misses        51800   51984     +184     
- Partials       2032    2033       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/games/strategy/triplea/ai/AbstractAi.java 1.02% <ø> (ø) 2 <0> (ø) ⬇️
...strategy/triplea/delegate/RandomStartDelegate.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../org/triplea/lobby/server/ModeratorController.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rg/triplea/lobby/server/db/MutedMacController.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/triplea/server/ServerConfiguration.java 0% <0%> (ø) 0% <0%> (?)
.../java/org/triplea/http/client/ServiceResponse.java 50% <0%> (ø) 4% <0%> (?)
...http/spark/controller/ControllerConfiguration.java 0% <0%> (ø) 0% <0%> (?)
...a/http/client/error/report/create/ErrorReport.java 60% <0%> (ø) 4% <0%> (?)
...in/java/org/triplea/http/client/ServiceClient.java 0% <0%> (ø) 0% <0%> (?)
...client/github/issues/GithubIssueClientFactory.java 0% <0%> (ø) 0% <0%> (?)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdc446...6c50cde. Read the comment docs.

@DanVanAtta
Copy link
Member

I think this is good to go 👍

I was not able to pinpoint the exact reason/cause, but it looks like this commit added this pause: 02a4a7e

In that changelog:

Changes for 1.7
* Created user interface element for RandomStartDelegate, so that players can pick which territory they want and what units they want in it. (veqryn)

* Gave all AIs methods to pick territories, and they will attempt to focus on a single area of the board. (veqryn)

* Created new game option property, "Territories Are Assigned Randomly", which determines if territories are randomly assigned or picked by players during RandomStartDelegate. (veqryn)

It looks like this would have been to support the pick territory phase to support risk style rules.

@DanVanAtta DanVanAtta merged commit 058adc7 into master Mar 19, 2019
@DanVanAtta DanVanAtta deleted the RandomStartDelegate_Remove_Pauses branch March 19, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants