Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding R Language Collective room to Sloshy #48

Closed
wants to merge 1 commit into from
Closed

Adding R Language Collective room to Sloshy #48

wants to merge 1 commit into from

Conversation

MdoubleDash
Copy link
Contributor

No description provided.

@MdoubleDash MdoubleDash closed this by deleting the head repository May 1, 2023
@MdoubleDash
Copy link
Contributor Author

@ndattani
Copy link
Contributor

ndattani commented May 2, 2023

I'll point out that this RO is a Community Manager (a type of Stack Exchange employee): https://stackoverflow.com/users/21182738/sasha

@ndattani
Copy link
Contributor

ndattani commented May 3, 2023

Since the changes in this version (#48 https://github.com/tripleee/sloshy/pull/48/files) are identical to the changes in #49 (https://github.com/tripleee/sloshy/pull/49/files), I wonder why deleted the head in #48 and opened a new (identical) pull request #49?

@tripleee
Copy link
Owner

tripleee commented May 4, 2023

My understanding is that the first PR was redacted because they had not yet received approval from a room owner. For the record, marking the PR as incomplete with a simple comment, and adding the missing information later would probably be smoother. (Github lets you mark a PR as WIP for Work In Progress, but the volume of PRs is obviously low in this project, so we don't strictly need to stick to formalities.)

@tripleee tripleee added the duplicate This issue or pull request already exists label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants