Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-11491 Disabled add managed button when a user doesn't have the right permission #920

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

elysee15
Copy link
Contributor

Scope of changes

sc-11491 Disabled add managed button when a user doesn't have the right permission

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/11491/disabled-add-managed-button-when-a-user-doesn-t-have-the-right-permission

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 44.38% // Head: 47.47% // Increases project coverage by +3.09% 🎉

Coverage data is based on head (df0630d) compared to base (6a4efdd).
Patch has no changes to coverable lines.

❗ Current head df0630d differs from pull request most recent head 870b6d3. Consider uploading reports for the commit 870b6d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   44.38%   47.47%   +3.09%     
==========================================
  Files         680      281     -399     
  Lines       24509    20731    -3778     
  Branches     1548      667     -881     
==========================================
- Hits        10878     9842    -1036     
+ Misses      12241     9514    -2727     
+ Partials     1390     1375      -15     
Flag Coverage Δ
unittests 47.47% <ø> (+3.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/src/components/AddNewVaspForm/AddNewVaspForm.tsx
...src/components/AddNewVaspModal/AddNewVaspModal.tsx
web/gds-user-ui/src/utils/permission.ts
...src/components/Section/MembershipGuide.stories.tsx
...cateRegistration/CerticateRegistration.stories.tsx
...s-user-ui/src/components/NameIdentifiers/index.tsx
...s-user-ui/src/components/ui/ErrorMessage/index.tsx
...uest/ConfirmIdentityCertificateRequest.stories.tsx
web/gds-user-ui/src/hooks/usePersistedState.ts
...-ui/src/components/SectionStatus/SectionStatus.tsx
... and 390 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elysee15 elysee15 force-pushed the sc-11491 branch 2 times, most recently from f7d7a4a to df0630d Compare November 30, 2022 16:31
@masskoder masskoder merged commit 340dc02 into main Nov 30, 2022
@masskoder masskoder deleted the sc-11491 branch November 30, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants