Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-10525: change name implementation #952

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Conversation

masskoder
Copy link
Collaborator

@masskoder masskoder commented Dec 8, 2022

Scope of changes

This allows the users to update their fullname.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 43.99% // Head: 43.97% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (693da51) compared to base (711496a).
Patch coverage: 14.28% of modified lines in pull request are covered.

❗ Current head 693da51 differs from pull request most recent head db91ef2. Consider uploading reports for the commit db91ef2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   43.99%   43.97%   -0.03%     
==========================================
  Files         688      691       +3     
  Lines       25573    25589      +16     
  Branches     1562     1565       +3     
==========================================
+ Hits        11252    11253       +1     
- Misses      12874    12889      +15     
  Partials     1447     1447              
Flag Coverage Δ
unittests 43.97% <14.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/gds-user-ui/src/application/api/user.ts 0.00% <0.00%> (ø)
...-ui/src/components/UserProfile/ChangeNameModal.tsx 0.00% <ø> (ø)
...b/gds-user-ui/src/components/UserProfile/index.tsx 30.00% <ø> (ø)
...ui/src/components/UserProfile/useCreateUserName.ts 0.00% <0.00%> (ø)
...r-ui/src/components/UserProfile/ChangeNameForm.tsx 16.66% <16.66%> (ø)
web/gds-user-ui/src/utils/react-query.ts 100.00% <100.00%> (ø)
...gds-user-ui/src/components/Collaborators/index.tsx 13.88% <0.00%> (-1.91%) ⬇️
web/gds-admin-ui/src/utils/index.js 46.15% <0.00%> (-0.70%) ⬇️
...-user-ui/src/components/Sidebar/SidebarContent.tsx 7.14% <0.00%> (ø)
.../pages/app/details/BasicDetails/dashboard/Tasks.js 59.09% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit 309b3c3 into main Dec 9, 2022
@masskoder masskoder deleted the sc-10525/update-user-name branch December 9, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants