Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-10829 Implement preview content feature #957

Merged
merged 1 commit into from
Dec 21, 2022
Merged

sc-10829 Implement preview content feature #957

merged 1 commit into from
Dec 21, 2022

Conversation

elysee15
Copy link
Contributor

Scope of changes

sc-10829 Implement preview content feature

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/10829/implement-preview-content-feature-along-quilljs-editor

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested review from bbengfort and masskoder and removed request for bbengfort December 12, 2022 17:43
@elysee15 elysee15 force-pushed the fix/sc-10829 branch 2 times, most recently from 5bd2bd7 to cb83a67 Compare December 12, 2022 19:53
@masskoder masskoder merged commit aa59cc6 into main Dec 21, 2022
@masskoder masskoder deleted the fix/sc-10829 branch December 21, 2022 22:30
DanielSollis pushed a commit that referenced this pull request Mar 30, 2023
@elysee15
sc-10829 Implement preview content feature (#957)
f851181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masskoder masskoder masskoder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elysee15 @masskoder