Debug Sentry Transactions #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbengfort
commented
Dec 26, 2022
pdamodaran
reviewed
Dec 27, 2022
pdamodaran
reviewed
Dec 27, 2022
| } | ||
|
|
||
| func StreamType(info *grpc.StreamServerInfo) string { | ||
| if !info.IsClientStream && !info.IsServerStream { |
There was a problem hiding this comment.
Since this is only called in StreamLogging, which only accepts grpc.ServerStreams, do we really need to check here for unary RPC's?
There was a problem hiding this comment.
I think we do - if we don't handle all cases of the different combination of bools then the default will be "bidirectional" and that's not the case when they're both false.
|
@pdamodaran @DanielSollis I've made the changes you've requested and I believe I've fixed the tests as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Updates the use of our interceptors for better Sentry handling.
Fixes SC-12088
Type of change
Acceptance criteria
This is mostly a refactoring of our interceptors so that we chain them together more like standard middleware. However, we want to ensure that no part of our previous middlewares is missed and that the behavior of this new middleware should be the same as the old.
Author checklist
Reviewer(s) checklist