Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certman leveldb tests #980

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Certman leveldb tests #980

merged 3 commits into from
Jan 11, 2023

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Jan 9, 2023

Scope of changes

This adds leveldb testing to the certman test suite. Previously the certman tests only tested with trtl as the underlying database. This creates another test suite which runs the same certman tests, but with leveldb as the underlying store instead.

We were already using the store abstraction for certman so this turned out to be pretty simple.

Type of change

  • bug fix
  • new feature
  • documentation
  • tests

Acceptance criteria

There should now be two separate tests suites when we run the certman tests, one for leveldb and the other for trtl.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Copy link
Collaborator

@daniellemaxwell daniellemaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pdeziel pdeziel merged commit 4680396 into main Jan 11, 2023
@pdeziel pdeziel deleted the sc-7851 branch January 11, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants