Sc-14469: Implement trtl CreateContact #997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2023 08:23
pdeziel
approved these changes
Apr 13, 2023
| // Normalize the email and convert to bytes | ||
| trimmed := strings.TrimSpace(c.Email) | ||
| normalized := strings.ToLower(trimmed) | ||
| key := []byte(normalized) |
There was a problem hiding this comment.
One thing that might be helpful would be to add a Key() method to the models.Contact which returns the key. Then we wouldn't have to have this conversion code in multiple places.
| Value: data, | ||
| Namespace: wire.NamespaceContacts, | ||
| } | ||
| if reply, err := s.client.Put(ctx, request); err != nil || !reply.Success { |
There was a problem hiding this comment.
Can you remind me, when does client.Put return err == nil and reply.Success == true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Implements CreateContact in store/trtl
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist
Reviewer(s) checklist