Fix bugs exposed by syntax tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just fixed top level scopes using the reduction method I mentioned in #58. Now the syntax tests for almost all languages pass perfectly. The following languages still fail:
But things are now looking much much much better. Even the languages with failures produce highlighting that looks mostly correct. |
|
I did some benchmarking and didn't see any noticeable regression. There might be one of a percent or two but that doesn't really matter. It's easy to add a fast path later if it is needed. I'm going to do some rebasing to get rid of redundant changing of the packs, then probably merge the package update and this. |
so that the meta scopes from the context being set from apply to the match pattern that invoked the set. Fixes most syntax test failures in the Default Packages.
Makes it output a bit less things. This may have increased test failures in ASP for some reason, even though I don't see anything that would change the highlighting behaviour. I'll try and debug that...
The order of the captures matters for the order of the resulting scope stack. It would also work with a BTreeMap but since we only ever iterate it in order, a Vec is probably faster/better.
such assertion lines always pass due to the selector being empty
trishume
changed the title
|
I moved my comment about the things that are still failing to #59. Please discuss further failures there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs found by running Sublime's syntax tests. Mostly fixing #51 with a total overhaul of the push/pop/set behaviour. This is a collaboration with @keith-hall that I did a couple weeks ago but haven't finished yet.