Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't map a generic array #66

Merged

Conversation

hborders
Copy link

Demonstrates a bug where attempting to map to a generic array of a generic superclass whose type is specified explicitly by a subclass always yields nil.

@tristanhimmelman tristanhimmelman merged commit fe87252 into tristanhimmelman:master Feb 17, 2015
@tristanhimmelman
Copy link
Owner

Hi there,
There we a couple issues with the code in your PR. I was able to get your test case working by doing the following:

  • The Generic type within the WithGenericArray needed to conform to Mappable
  • The JSON string passed into the testSubclassWithGenericArrayInSuperclass() function had a bug in the array format
    I committed my changes and merged them into master if you want to take a look.
    Tristan

@hborders
Copy link
Author

Thanks! I applied your suggested fix and my internal code works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants