Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared -> LinearLayout conversion #4038

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Shared -> LinearLayout conversion #4038

merged 8 commits into from
Jun 4, 2024

Conversation

jlebar
Copy link
Collaborator

@jlebar jlebar commented May 30, 2024

No description provided.

@jlebar jlebar force-pushed the ll branch 2 times, most recently from abe5812 to 2af5383 Compare May 30, 2024 23:49
@jlebar jlebar force-pushed the ll branch 2 times, most recently from 1430ff8 to a672b27 Compare June 1, 2024 00:22
@jlebar
Copy link
Collaborator Author

jlebar commented Jun 2, 2024

This seems to be passing our internal tests and benchmarks. I'll prepare it for review.

@jlebar jlebar requested a review from ThomasRaoux June 3, 2024 21:35
@jlebar
Copy link
Collaborator Author

jlebar commented Jun 3, 2024

Woo, @ThomasRaoux this is ready for you to look at.

Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping for velocity, I'll send some feedback async if any

@jlebar jlebar marked this pull request as ready for review June 4, 2024 20:58
@jlebar jlebar requested a review from ptillet as a code owner June 4, 2024 20:58
@jlebar jlebar changed the title [WIP] Shared -> LinearLayout conversion Shared -> LinearLayout conversion Jun 4, 2024
@jlebar jlebar merged commit 854b13d into main Jun 4, 2024
6 checks passed
@jlebar jlebar deleted the ll branch June 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants