Melody compiler should warn for mounts with no keys (no 'as')

[jamesb3ll]

The compiler should warn if a mount has no key:
{% mount 'component.js' %}
Should be:
{% mount 'component.js' as 'key' %}

Especially in for-loops mounts should have keys.

Also update the documentation and emphasise on this.

[ayusharma]

@jamesb3ll @pago Should all mount decelerations without as key parameters have warning or should it only be in for-loops ?

I think, we can check this here

melody/packages/melody-extension-core/src/parser/mount.js

Line 45 in 27745d7

if (tokens.nextIf(Types.SYMBOL, 'as')) {

[efegurkan]

Hey, @ayusharma

It should be for all of them AFAIK. It can be problematic in case of for loops, we are planning to enforce it.

[ayusharma]

we are planning to enforce it.

It's better to throw an error in that condition.

Please let me know the error format.

I am thinking of this.

parser.warn({
              title: "Missing 'as' key with mount.",
              pos: tokens.la(0).pos,
              advice: "There should be an 'as' argumnet with a 'key' in mount statement."
            });

[pago]

Has been fixed by @ayusharma and will be part of Melody 1.2.0