Add HQMTool folder #10

DavidAKopriva · 2021-09-09T15:42:36Z

Add the code, documentation and examples to the repo for the HQMTool interactive front end.

codecov · 2021-09-09T15:44:59Z

Codecov Report

Merging #10 (0d25434) into main (8a781fc) will decrease coverage by 97.61%.
The diff coverage is 0.11%.

@@             Coverage Diff             @@
##              main     #10       +/-   ##
===========================================
- Coverage   100.00%   2.38%   -97.62%     
===========================================
  Files            1      21       +20     
  Lines           40    1762     +1722     
===========================================
+ Hits            40      42        +2     
- Misses           0    1720     +1720

Flag	Coverage Δ
unittests	`2.38% <0.11%> (-97.62%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/ControlFile/ControlFileOperations.jl	`0.00% <0.00%> (ø)`
src/Curves/CurveOperations.jl	`0.00% <0.00%> (ø)`
src/Curves/Spline.jl	`0.00% <0.00%> (ø)`
src/HQMTool.jl	`0.00% <0.00%> (ø)`
src/Mesh/Meshing.jl	`0.00% <0.00%> (ø)`
src/Misc/DictionaryOperations.jl	`0.00% <0.00%> (ø)`
src/Misc/NotificationCenter.jl	`0.00% <0.00%> (ø)`
src/Model/Geometry.jl	`0.00% <0.00%> (ø)`
src/Project/BackgroundGridAPI.jl	`0.00% <0.00%> (ø)`
src/Project/ControlInputAPI.jl	`0.00% <0.00%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8c375...0d25434. Read the comment docs.

coveralls · 2021-09-09T15:46:19Z

coverage: 1.826% (-98.2%) from 100.0%
when pulling e3b5b5c on InteractiveTool
into 0cd454b on main.

* Integrate docs * Store png on GitHub * Push documentation previews * Fix docs; move sources * Move AllFeatures.control to examples folder * Add Printf dependency * Rearrange files * Fix path * Fix docs * Hopefully make tests pass again

sloede · 2021-09-11T09:37:45Z

@DavidAKopriva There has been a small change to how this branch can be used from now on: You also need to explicitly use GLMakie.jl, since it is not included as a hard dependency anymore. We use the same procedure for Trixi to make it easier for those who do not have GL installed or who only need the mesh generation without plotting.

That is, to load HOHQMesh from this branch with plotting enabled, you need to execute

julia> using Revise, GLMakie, HOHQMesh

Please let me know if you have any questions or if something doesn't work as expected.

DavidAKopriva · 2021-09-13T16:58:54Z

Just starting to see how the new version runs. I get the following message on the first run:

┌ Warning: Package HOHQMesh does not have Printf in its dependencies:
│ - If you have HOHQMesh checked out for development and have
│ added Printf as a dependency but haven't updated your primary
│ environment's manifest file, try Pkg.resolve().
│ - Otherwise you may need to report an issue with HOHQMesh
└ Loading Printf into HOHQMesh from project dependency, future warnings for HOHQMesh are suppressed.

DavidAKopriva · 2021-09-13T17:03:27Z

And

    proj.plt = Figure(resolution = (1500, 1500))

gives the error

UndefVarError: Figure not defined

even though I did run

using Revise, GLMakie, HOHQMesh

DavidAKopriva · 2021-09-13T17:18:49Z

Works if using GLMakie is returned to the vizProject file. But mesh doesn't plot anymore in runDemo. probably a directory issues.

sloede · 2021-09-13T18:07:18Z

Just starting to see how the new version runs. I get the following message on the first run:

┌ Warning: Package HOHQMesh does not have Printf in its dependencies:
│ - If you have HOHQMesh checked out for development and have
│ added Printf as a dependency but haven't updated your primary
│ environment's manifest file, try Pkg.resolve().
│ - Otherwise you may need to report an issue with HOHQMesh
└ Loading Printf into HOHQMesh from project dependency, future warnings for HOHQMesh are suppressed.

Please delete the Manifest.toml file in your branch directory and try again. The error should disappear. If not, please let me know.

sloede · 2021-09-13T18:11:45Z

And
    proj.plt = Figure(resolution = (1500, 1500))
gives the error

UndefVarError: Figure not defined

even though I did run

using Revise, GLMakie, HOHQMesh

Works if using GLMakie is returned to the vizProject file. But mesh doesn't plot anymore in runDemo. probably a directory issues.

Hm, I cannot reproduce either error. Have you started Julia from within the HOHQMesh.jl/ directory with

julia --project=.

and then executed

julia> using Revise, HOHQMesh, GLMakie

julia> HOHQMesh.runDemo()

?

This yields for me the following plot:

sloede · 2021-09-13T18:14:29Z

FWIW, there should be no need to re-add using GLMakie to any of the files, since we are already using Makie via the line

HOHQMesh.jl/src/HOHQMesh.jl

Line 15 in e3b5b5c

using .Makie

in src/HOHQMesh.jl.

DavidAKopriva · 2021-09-13T20:00:51Z

Yes, the plot is missing the mesh that plots after the "any key" is hit. I'm using VScode, so I'm not sure what the directory is, but I will try pwd to see.

DavidAKopriva · 2021-09-13T20:04:13Z

Not sure why all the gymnastics.

julia> --project=.
ERROR: syntax: invalid operator "--"
Stacktrace:
[1] top-level scope
@ none:1

sloede · 2021-09-13T20:21:29Z

Yes, the plot is missing the mesh that plots after the "any key" is hit. I'm using VScode, so I'm not sure what the directory is, but I will try pwd to see.

I can confirm that the mesh is missing for me, too. Dunno why though. It seems weird that everything works except the mesh visualization. Maybe because it's now contained in a module? Needs to be investigated...

Not sure why all the gymnastics.

julia> --project=.
ERROR: syntax: invalid operator "--"
Stacktrace:
[1] top-level scope
@ none:1

The julia --project=. refers to how you start Julia from the command line. It's not something you execute in the REPL. VS Code should allow something similar, but I've never used it - maybe @jlchan or @ranocha can help?

ranocha · 2021-09-15T07:36:48Z

The julia --project=. refers to how you start Julia from the command line. It's not something you execute in the REPL. VS Code should allow something similar, but I've never used it - maybe @jlchan or @ranocha can help?

I don't use the terminal of VSCode, sorry

jlchan · 2021-09-15T13:27:24Z

If I understand correctly, the --project=. flag just specified the environment to activate on Julia startup. For VSCode, one should be able to achieve the same effect by making a new window and having VSCode open the folder containing the environment to activate.

andrewwinters5000 · 2022-03-12T21:40:36Z

We need to write some tests to cover all the new HQMTool routines. Everything works but we should not let coverage drop from 100% to 2%

DavidAKopriva · 2022-03-12T22:33:33Z

I presume Julia has a built in testing API like python and Java do? I'll have a look. If so, I hope it is easy to set up.

andrewwinters5000 · 2022-03-25T10:51:13Z

Development of the HQMTool has moved entirely #15

Add HQMtool folder

77bd6ca

Add the code, documentation and examples to the repo for the HQMTool interactive front end.

DavidAKopriva and others added 5 commits March 1, 2022 13:23

Add source and docs

47d0152

add capability to set ABAQUS for the meshFileFormat

16be727

add ability to plot mesh from ISM format version

8bbc47f

Merge branch 'main' into InteractiveTool

164dda5

add capability to plot from the ABAQUS format as well

0d25434

andrewwinters5000 closed this Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HQMTool folder #10

Add HQMTool folder #10

DavidAKopriva commented Sep 9, 2021

codecov bot commented Sep 9, 2021 •

edited

Loading

coveralls commented Sep 9, 2021 •

edited

Loading

sloede commented Sep 11, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

sloede commented Sep 13, 2021

sloede commented Sep 13, 2021

sloede commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

sloede commented Sep 13, 2021

ranocha commented Sep 15, 2021

jlchan commented Sep 15, 2021

andrewwinters5000 commented Mar 12, 2022

DavidAKopriva commented Mar 12, 2022

andrewwinters5000 commented Mar 25, 2022

Add HQMTool folder #10

Add HQMTool folder #10

Conversation

DavidAKopriva commented Sep 9, 2021

codecov bot commented Sep 9, 2021 • edited Loading

Codecov Report

coveralls commented Sep 9, 2021 • edited Loading

sloede commented Sep 11, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

sloede commented Sep 13, 2021

sloede commented Sep 13, 2021

sloede commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

DavidAKopriva commented Sep 13, 2021

sloede commented Sep 13, 2021

ranocha commented Sep 15, 2021

jlchan commented Sep 15, 2021

andrewwinters5000 commented Mar 12, 2022

DavidAKopriva commented Mar 12, 2022

andrewwinters5000 commented Mar 25, 2022

codecov bot commented Sep 9, 2021 •

edited

Loading

coveralls commented Sep 9, 2021 •

edited

Loading