Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer() and @trixi_timeit #25

Merged
merged 10 commits into from
Jun 10, 2024
Merged

Add timer() and @trixi_timeit #25

merged 10 commits into from
Jun 10, 2024

Conversation

efaulhaber
Copy link
Member

This is another good candidate to have in TrixiBase.jl, as it's exactly identical code in Trixi and TrixiParticles.
Check out trixi-framework/TrixiParticles.jl#543 to see this in action.

@efaulhaber efaulhaber added the enhancement New feature or request label Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (82ae2f7) to head (e2894f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   94.59%   95.00%   +0.40%     
==========================================
  Files           4        5       +1     
  Lines          74       80       +6     
==========================================
+ Hits           70       76       +6     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9416573547

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9416720838

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9416720838

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9416766134

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. Please find below some suggestions

src/trixi_timeit.jl Outdated Show resolved Hide resolved
src/trixi_timeit.jl Outdated Show resolved Hide resolved
test/test_timers.jl Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9445418325

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9445418325

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

@efaulhaber efaulhaber requested a review from ranocha June 10, 2024 09:22
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have a few minor additional suggestions.

src/trixi_timeit.jl Outdated Show resolved Hide resolved
src/trixi_timeit.jl Outdated Show resolved Hide resolved
src/trixi_timeit.jl Outdated Show resolved Hide resolved
src/trixi_timeit.jl Outdated Show resolved Hide resolved
efaulhaber and others added 2 commits June 10, 2024 17:06
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
efaulhaber and others added 2 commits June 10, 2024 17:06
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@efaulhaber efaulhaber requested a review from ranocha June 10, 2024 15:06
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9450836757

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9450836757

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.0%

Totals Coverage Status
Change from base Build 9328142445: 0.4%
Covered Lines: 76
Relevant Lines: 80

💛 - Coveralls

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit f4554e8 into main Jun 10, 2024
15 checks passed
@ranocha ranocha deleted the ef/timers branch June 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants