-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timer()
and @trixi_timeit
#25
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 94.59% 95.00% +0.40%
==========================================
Files 4 5 +1
Lines 74 80 +6
==========================================
+ Hits 70 76 +6
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9416573547Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9416720838Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9416720838Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9416766134Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea. Please find below some suggestions
Pull Request Test Coverage Report for Build 9445418325Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9445418325Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just have a few minor additional suggestions.
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Pull Request Test Coverage Report for Build 9450836757Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9450836757Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is another good candidate to have in TrixiBase.jl, as it's exactly identical code in Trixi and TrixiParticles.
Check out trixi-framework/TrixiParticles.jl#543 to see this in action.