Model & Client Audit #43
Conversation
…ug being a string.
Add ForwardingRulesList, the list request used in adding/removing. Explicit ForwardRule request (1 optional value type) and response class. LoadBalancer request modified, 2 optional value types.
Forgot to removed un-necessary JsonPropertAttributes from response
…move un-necessary JsonPropertyAttributes from response class. Rename type->Type
…Create method. Move ImageType enum to its own file. Simplify GetAll switch logic.
There is no UpdateFingerprint to Test.
4 optional value type properties.
…s for Tag/Untag methods. Renamed request Resource->TagResource and move into its own file. Rename Resource->TagResourcesStatistics, strongly typed respone class. Add missing props. Created Base TagResourceStatistics class as well.
|
I just noticed some of these issues myself when rewriting the README. Great timing! 👍 |
|
If we're going to have |
Since you raised it, I think so for sure. I'll add it now. I wasn't too sure at first about creating a duplicate class with just the class name being different, but it makes for a clean implementation and easy for future changes. There was another case where one class was used as both Request/Response, |
Yeah, I just mentioned that in my first review. |
|
I also found a some new (or missing) properties for certain request/response models, as well as few missing methods. I'll be adding those as a second PR after this. I made this PR exclusively for all the things that would be clear breakages in API. |
I just made an issue noting the major missing features #45. Could you comment there if you work on any of those in your mentioned PR. |
|
Going on a break for now. I think that covers everything mentioned so far. |
|
I noticed in Also. public class Network {
public List<Interface> v4 { get; set; }
public List<Interface> v6 { get; set; }
}These should be |
Done on both. Something else I noticed about the This ones a little odd because there doesn't seem to be any specific documentation on the Network object of the response. This is just what I've noticed from fully inspecting the responses. |
|
Yeah, I think having separate Interfaces is the correct move. They may differ further in the future. |
V6 uses integer for Netmask.
|
Could you also split |
|
Could you rebase on to |
* Switch to same enum style list call as Images * Should have been imageIdOrSlug all along. imageId being an int and slug being a string. * Rename ForwardingRules->ForwardingRule. Add ForwardingRulesList, the list request used in adding/removing. Explicit ForwardRule request (1 optional value type) and response class. LoadBalancer request modified, 2 optional value types. * Match filename to class name * Rename Address to IpAddress (same as Networks and DomainRecords) Forgot to removed un-necessary JsonPropertAttributes from response * Create explicit HealthCheck request class (4 optional value type), remove un-necessary JsonPropertyAttributes from response class. Rename type->Type * Change currency properties from float to Decimal type * Create Explicit UpdateImage class, convert Image to actual class for Create method. Move ImageType enum to its own file. Simplify GetAll switch logic. * Explicit UpdateKey class (can only update name currently). There is no UpdateFingerprint to Test. * Tags are always strings. 4 optional value type properties. * Rename request TagResource->TagResources, strongly typed request class for Tag/Untag methods. Renamed request Resource->TagResource and move into its own file. Rename Resource->TagResourcesStatistics, strongly typed respone class. Add missing props. Created Base TagResourceStatistics class as well. * Rename to ForwardingRules, the methods operate on multiple items. * Explicit UpdateDomainRecord class. * Explicit Requests class for StickySessions. * LoadBalancer id's are strings not ints * DomainRecord doc updates * Forgot [Fact] * Consistent usage of List over array. * Capitalization * Doc update * Should be a floating point, defaulting to double. * Separate V4 and V6 Interface classes. V6 uses integer for Netmask. * Split Action request into DropletAction and ImageAction.
Addresses #36
Went over all Request/Response models and Client methods against current API docs. Will be adding comments to particular code sections with reasoning behind changes. Most of the changes were creating an explicit Request or Response class (if one was used for both), or an explicit Update class, changing ValueType properties in Request classes to be Nullable if they were optional in particular request (and not marked as Nullable in Response because they are guaranteed to be present), and found some classes which seemed to be very incomplete (TagResources and ForwardingRules).
I'm going to add a Migrating to version 3.x section to the README.md as well, with summary of class/property changes that break API.