Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganized dependencies in setup.py #6

Merged
merged 2 commits into from
May 9, 2018
Merged

Reorganized dependencies in setup.py #6

merged 2 commits into from
May 9, 2018

Conversation

gseva
Copy link
Contributor

@gseva gseva commented May 7, 2018 •
edited by idontdomath
Loading

Reorganization of dependencies:

  • Removed dependencies of internal processes/reports.
  • Removed unused dependencies

ordonezf
ordonezf reviewed May 9, 2018
View reviewed changes
setup.py Outdated
query = ['SQLAlchemy==1.0.11']
postgres = query + ['psycopg2==2.6.1']
drive = ['PyDrive==1.3.1']
adwords = ['googleads==10.1.0']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently using version 11.0.1 for googleads

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, fixed

@idontdomath idontdomath self-requested a review May 9, 2018 14:30
ordonezf
ordonezf approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@ordonezf ordonezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gseva gseva merged commit ef1626e into master May 9, 2018
@gseva gseva deleted the ordering-dependencies branch May 9, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordonezf ordonezf ordonezf approved these changes

@idontdomath idontdomath idontdomath approved these changes

@PalmaLeandro PalmaLeandro Awaiting requested review from PalmaLeandro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gseva @idontdomath @ordonezf