match segment if remainingPath only consist of unknown qsParams #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first let me thank you for router5...we right now try to move to router5 from react-router - but encounter one issue that makes it harder then needed for us.
we have a lot of querystring params across our app that acts more global then route specific, eg:
?lng=...
?debug=...
we got qs params that act more on some react component, like eg. preselecting some filter
both have in common, that we don't want them to be defined on the route.
sample:
router.addNode('userModify', '/user/modify/:userId')
open
http://localhost/user/modifiy/1234?lng=de
would result in not found route.this PR would change it so if a
remainingPath
ingetSegmentsMatchingPath
will be ignored if only consist of unmatched querystring params. Personally i think it would make more sense this way. See changed test in commit.