Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Data.define as a class definition #1725

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Treat Data.define as a class definition #1725

merged 2 commits into from
Aug 9, 2023

Conversation

mvz
Copy link
Collaborator

@mvz mvz commented Jul 4, 2023

Fixes #1682

  • Make Reek::AST::SexpExtensions::SendNode.module_creation_receiver? private
  • Recognize that Data.define creates a new class

mvz added 2 commits July 4, 2023 20:56
@mvz
Make Reek::AST::SexpExtensions::SendNode.module_creation_receiver? pr…
4b25738 
…ivate

This method is only used by other methods in the same module.
@mvz
Recognize that Data.define creates a new class
90ce058 
Data.define is similar to Class.new and Struct.new.
@mvz mvz requested review from chastell and troessner July 4, 2023 19:35
@mvz mvz merged commit 4f72149 into master Aug 9, 2023
@mvz mvz deleted the handle-data-define branch August 9, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troessner troessner troessner approved these changes

@chastell chastell Awaiting requested review from chastell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ModuleInitialize false positive with custom Data constructor
2 participants
@mvz @troessner