Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common authentication failure error code #302

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

themiron
Copy link
Contributor

Useful for human-readable logging and can be used for additional logic of custom plugins/further script actions.
For example it's currently used for asuscomm.com in https://github.com/RMerl/asuswrt-merlin.ng

Useful for human-readable logging and can be used for additional
logic of custom plugins/further script actions.
@troglobit
Copy link
Owner

Great stuff, again!

@troglobit troglobit merged commit 1a3a933 into troglobit:master Feb 25, 2020
@themiron
Copy link
Contributor Author

Many thanks.
NB, only generic "badauth", cloudflare and http 401/403 are handled how.
Guess some of ddns services do have custom auth fail responses, corresponding support can be added later when noticed, not aware of that at the moment

@troglobit
Copy link
Owner

I noticed. Yeah, now we have the error code at least, so adding it to other plugins where available can be done later 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants