Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CloudFlare support #329

Merged
merged 11 commits into from
Jan 4, 2021
Merged

Enhance CloudFlare support #329

merged 11 commits into from
Jan 4, 2021

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jan 3, 2021 •
edited
Loading

  • This PR adds two cloudflare options: ttl and proxied.
  • Use https://1.1.1.1/cdn-cgi/trace to get current ip address.
  • Fix a bug where it will fail to update if there is no existing A/AAAA record.
  • Add a few cloudflare examples.
  • Updated man page and README for new option and config exampels.

Fixes #323.

@troglobit
Copy link
Owner

Awesome work, thank you! Only thing I'd like is for the README and manual page to be updated for the Cloudflare plugin, specifically. Only updating the examples would be sufficient since no other plugin supports ttl or proxied atm. Fix that (on the same branch/pull-reqeust is OK) and I'll merge this 😃👍

@ntkme ntkme changed the title Add ttl and proxied option for cloudflare Enhance CloudFlare support Jan 3, 2021
@ntkme
Copy link
Contributor Author

ntkme commented Jan 3, 2021

@troglobit Sorry for making the scope of this PR bigger than original. I think it is ready for another review. All 5 commits are independent and can be reviewed separately.

@troglobit
Copy link
Owner

No problem. Looks good to me, only missing the manual page update. Would be really appreciated if you could complement the example in man/inadyn.conf.5, similar to the README update.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 4, 2021

Updated man page and README.

Also, added a dual stack cloudflare-ipv4-ipv6.conf to demonstrate how to configure both ipv4 and ipv6 ddns at the same time.

@troglobit
Copy link
Owner

Perfect, great job with this, thank you! ❤️

@troglobit troglobit merged commit 55eef2c into troglobit:master Jan 4, 2021
@ntkme ntkme deleted the cloudflare branch January 4, 2021 13:21
troglobit added a commit that referenced this pull request Aug 9, 2023
@troglobit
Fix #421: use Docker :latest tag only for latest In-a-Dyn release
f829d7f 
Ever since first adding support for building containers, PR #329,
In-a-Dyn container images have applied the :latest tag wrong.

According to best practices[1], the :latest tag should be applied
to the latest release of a software, not the latest build.

This patch changes that, using GitHub action variables[2] to set up a
list of tags or generate a version for tagging.  The docker builders
take multiple tags separated with comma[3] (',') and for GHCR we simply
use a for-loop.

[1]: https://stevelasker.blog/2018/03/01/docker-tagging-best-practices-for-tagging-and-versioning-docker-images/
[2]: https://docs.github.com/en/actions/learn-github-actions/variables
[3]: https://github.com/docker/build-push-action

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare Proxy support
2 participants
@ntkme @troglobit