Add a "Test Connection" button to the main activity #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oasiscifr
reviewed
Jan 27, 2020
| private class TestConnection extends AsyncTask<String, Void, TestConnectionResult> { | ||
| protected void onPreExecute() { | ||
| super.onPreExecute(); | ||
| testConnectionButton.setText(R.string.testing); |
There was a problem hiding this comment.
Disable the button when the test is in progress
|
Fixed |
|
To pull upstream commits to your developing branch, |
|
LGTM 🍻 |
|
Nice, thanks for telling me this, I'll use rebase next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This button will test connection to https://www.google.com and show the result in a toast.
When succeed: show the time been used
When failed: show error message