-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test building Linux CUDA miner on CI #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically downloading and installing CUDA seems a bit over the top.
Could you rewrite the test to just check if CUDA is already available, and if not, skip the test?
... at the expense of losing control of toolkit version. References: * [Travis CI apt addon doc](https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages) * Package name [nvidia-cuda-toolkit](https://github.com/travis-ci/apt-package-safelist/blob/139a20ccd62a9578ede0597de1f5d1f7d16f470c/ubuntu-trusty#L11030) Addresses tromp#66 (review)
... at the expense of losing control of toolkit version. References: * [Travis CI apt addon doc](https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages) * Package name [nvidia-cuda-toolkit](https://github.com/travis-ci/apt-package-safelist/blob/139a20ccd62a9578ede0597de1f5d1f7d16f470c/ubuntu-trusty#L11030) If only package `nvidia-cuda-toolkit` installed, CI failes with following error: ``` The following packages have unmet dependencies: nvidia-cuda-toolkit : Depends: nvidia-profiler (= 5.5.22-3ubuntu1) but it is not going to be installed Depends: nvidia-cuda-dev (= 5.5.22-3ubuntu1) but it is not going to be installed E: Unable to correct problems, you have held broken packages. apt-get install failed ``` Addresses tromp#66 (review)
... at the expense of losing control of toolkit version. References: * [Travis CI apt addon doc](https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages) * Package name [nvidia-cuda-toolkit](https://github.com/travis-ci/apt-package-safelist/blob/139a20ccd62a9578ede0597de1f5d1f7d16f470c/ubuntu-trusty#L11030) If only package `nvidia-cuda-toolkit` installed, CI failes with following error: ``` The following packages have unmet dependencies: nvidia-cuda-toolkit : Depends: nvidia-profiler (= 5.5.22-3ubuntu1) but it is not going to be installed Depends: nvidia-cuda-dev (= 5.5.22-3ubuntu1) but it is not going to be installed E: Unable to correct problems, you have held broken packages. apt-get install failed ``` Addresses tromp#66 (review)
@tromp I am not sure I get what you suggest. This is the CI configuration, so we know that CUDA toolkit is absent (no CUDA hardware or driver is needed in order to build the miner). So, if we want to have CI test building the CUDA miner, we need to configure CI to automatically download and install CUDA. There are two options:
I tried option B without success still getting
|
dear Luca,
There are two options:
(A) Download and install step by step as a user would. This is what this PR does.
(B) Download and install relying on Travis CI apt addon.
I'd prefer to try to get option (B) working.
I tried option B without success still getting nvcc fatal : Unknown option 'std'.
Perhaps due to my recent Makefile change introducing
NVCC ?= nvcc -std=c++11
This means that if you first define NVCC=nvcc it will avoid the -std option.
Could you try to get that to work?
regards,
-John
|
... at the expense of losing control of toolkit version. References: * [Travis CI apt addon doc](https://docs.travis-ci.com/user/installing-dependencies/#adding-apt-packages) * Package name [nvidia-cuda-toolkit](https://github.com/travis-ci/apt-package-safelist/blob/139a20ccd62a9578ede0597de1f5d1f7d16f470c/ubuntu-trusty#L11030) If only package `nvidia-cuda-toolkit` installed, CI fails with following error: ``` The following packages have unmet dependencies: nvidia-cuda-toolkit : Depends: nvidia-profiler (= 5.5.22-3ubuntu1) but it is not going to be installed Depends: nvidia-cuda-dev (= 5.5.22-3ubuntu1) but it is not going to be installed E: Unable to correct problems, you have held broken packages. apt-get install failed ``` If macro `NVCC=nvcc` not passed to `make`, CI fails with `nvcc fatal : Unknown option 'std'` ([ref](tromp#66 (comment))). Addresses tromp#66 (review)
|
How can it complain about both nvcc fatal : Unknown option 'std' and must be enabled with the -std=c++11 option ? I'm very confused... |
@lucafavatella You could cache the CUDA folders for later builds, see https://docs.travis-ci.com/user/caching/ So if the folder doesn't exist, run through the full installation once. Then if it exists, skip the installation. |
I do not plan to update this PR so closing. Things missing: |
No description provided.