Support for Pepco (MD,DC) #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I refactored the code to avoid duplicate code. There is now the Exelon base class and I was able to add support for all Exelon subsidiaries. Each subsidiary only needs to define the opower.com subdomain (I was able to get it for all of them via the GetConfiguration endpoint) and the domain that hosts the login page. Thanks! |
|
@tronikos Awesome! I pulled down the HACS integration and verified all is working with Pepco. Thanks again! |
|
Could you please take a look at #14 ? |
|
@tronikos Happy to take a look this evening after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was extremely easy to add! Thanks for making this library.