New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): optimize api compatibility #5408
Merged
halibobo1205
merged 2 commits into
tronprotocol:develop
from
lxcmyf:feature/optimize_api_parameters
Aug 22, 2023
Merged
feat(api): optimize api compatibility #5408
halibobo1205
merged 2 commits into
tronprotocol:develop
from
lxcmyf:feature/optimize_api_parameters
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxcmyf
force-pushed
the
feature/optimize_api_parameters
branch
2 times, most recently
from
August 9, 2023 16:47
5dcb204
to
9fa06c6
Compare
lxcmyf
force-pushed
the
feature/optimize_api_parameters
branch
3 times, most recently
from
August 15, 2023 06:42
ae280c5
to
dcca2c1
Compare
@lxcmyf Please add unit test to cover all changes. |
lxcmyf
force-pushed
the
feature/optimize_api_parameters
branch
from
August 16, 2023 13:35
dcca2c1
to
3c850af
Compare
317787106
reviewed
Aug 17, 2023
framework/src/main/java/org/tron/core/services/http/GetCanWithdrawUnfreezeAmountServlet.java
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/GetBlockByNumServlet.java
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/GetAccountServlet.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/GetAvailableUnfreezeCountServlet.java
Outdated
Show resolved
Hide resolved
chainbase/src/main/java/org/tron/core/db/ResourceProcessor.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/PostParams.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/ListProposalsServlet.java
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/GetAccountServlet.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/tron/core/services/http/GetAssetIssueListServlet.java
Show resolved
Hide resolved
It is still recommended to add all the test. |
lxcmyf
force-pushed
the
feature/optimize_api_parameters
branch
3 times, most recently
from
August 17, 2023 15:40
1856965
to
d0aa39c
Compare
lxcmyf
force-pushed
the
feature/optimize_api_parameters
branch
from
August 18, 2023 05:24
d0aa39c
to
5551012
Compare
317787106
approved these changes
Aug 22, 2023
halibobo1205
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
optimize api compatibility, close #5398
Why are these changes required?
This PR has been tested by:
Follow up
Extra details