Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): optimize api compatibility #5408

Merged

Conversation

lxcmyf
Copy link
Contributor

@lxcmyf lxcmyf commented Aug 9, 2023

What does this PR do?
optimize api compatibility, close #5398

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 2 times, most recently from 5dcb204 to 9fa06c6 Compare August 9, 2023 16:47
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 3 times, most recently from ae280c5 to dcca2c1 Compare August 15, 2023 06:42
@halibobo1205
Copy link
Contributor

halibobo1205 commented Aug 16, 2023

@lxcmyf Please add unit test to cover all changes.

@halibobo1205
Copy link
Contributor

@lxcmyf Please add unit test to cover all changes.

It is still recommended to add all the test.

@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch 3 times, most recently from 1856965 to d0aa39c Compare August 17, 2023 15:40
@lxcmyf lxcmyf force-pushed the feature/optimize_api_parameters branch from d0aa39c to 5551012 Compare August 18, 2023 05:24
Copy link
Contributor

@halibobo1205 halibobo1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halibobo1205 halibobo1205 merged commit ac90c45 into tronprotocol:develop Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization for certain API Interfaces
3 participants