{trpc, attachment}: pre-check empty attachment while getting or setting to avoid memory allocation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liuzengh
commented
Oct 11, 2023
liuzengh
commented
- return false if getting empty attachment to avoid memory allocation in io.ReadAll
- set non-nil server request attachment to avoid memory allocation
- rename: GetClientRequestAttachment => ClientRequestAttachment, GetServerResponseAttachment => ServerResponseAttachment
to avoid memory allocation. - return false if getting empty attachment to avoid memory allocation in io.ReadAll - set non-nil server request attachment to avoid memory allocation - rename: GetClientRequestAttachment => ClientRequestAttachment, GetServerResponseAttachment => ServerResponseAttachment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.