Simplify CI test matrix #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We historically tested against macOS, Windows, and multiple Node versions, because when I originally set up this repo, we were using Ember CLI to generate the build artifacts, and wanted to guarantee the behavior of the build integration across all targets. We have not used Ember CLI here for many years, though, and True Myth makes *zero* use of Node APIs. Accordingly, we can simply test using the current Node LTS (for convenience, really!) and make sure we have full type-checking coverage for our supported set of TS versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We historically tested against macOS, Windows, and multiple Node versions, because when I originally set up this repo, we were using Ember CLI to generate the build artifacts, and wanted to guarantee the behavior of the build integration across all targets. We have not used Ember CLI here for many years, though, and True Myth makes zero use of Node APIs. Accordingly, we can simply test using the current Node LTS (for convenience, really!) and make sure we have full type-checking coverage for our supported set of TS versions.