Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing #21

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Automated testing #21

merged 2 commits into from
Nov 17, 2023

Conversation

patham9
Copy link
Collaborator

@patham9 patham9 commented Nov 14, 2023

  • includes testing for ./metta files in ./extend

@Necr0x0Der
Copy link
Contributor

Necr0x0Der commented Nov 15, 2023

It is more related to #17 , but I'd propose to have a clean folder for the library/extension itself, i.e. without files which are not needed to the library itself. Thus, I'd move example* and test.py outside extend, possibly, to tests for now

@patham9
Copy link
Collaborator Author

patham9 commented Nov 15, 2023

I agree, hm how about ./extend/tests as it would separate it from the different kind of tests in the project root?

@Necr0x0Der
Copy link
Contributor

I suppose that we will have automatic library/extension installation for MeTTa, which will suppose a certain structure for libraries. Like in Python, everything in the folder can possibly become a part of the library. In the nearest future, I suppose that the folder name with the library code should have the name of the library (e.g., mettamorph) with something like __init__.metta (or whatever else Luke will propose), but since it is not supported yet, I'm not proposing to rename extend. However, I'd put these tests into tests/extend rather than extend/tests.

@patham9
Copy link
Collaborator Author

patham9 commented Nov 15, 2023

Sounds good, I will put them into tests/extend as you mentioned.

@Necr0x0Der
Copy link
Contributor

Sounds good, I will put them into tests/extend as you mentioned.

Will you do it within this PR?

@patham9
Copy link
Collaborator Author

patham9 commented Nov 16, 2023

I guess we can do it in a separate PR which could also address aspects of #17
If that is fine then you can probably merge it already.

@Necr0x0Der Necr0x0Der merged commit 87ae039 into main Nov 17, 2023
@Necr0x0Der Necr0x0Der deleted the Testing branch November 17, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants