Added models_config and gateway to make it easy to switch betwe… #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1LV3RJ1NX
reviewed
Jun 20, 2024
| model_config.parameters = {} | ||
| return ChatOpenAI( | ||
| model=model_config.name.split("/")[1], | ||
| temperature=model_config.parameters.get("temperature", 0.1), |
There was a problem hiding this comment.
Maybe add an optional model_kwargs
| @@ -27,7 +26,6 @@ | |||
| "query": "Explain in detail different categories of credit cards", | |||
| "model_configuration": { | |||
| "name": "openai-main/gpt-3-5-turbo", | |||
| "provider": "truefoundry", | |||
| "parameters": {"temperature": 0.1}, | |||
There was a problem hiding this comment.
What do think on changing this payload similar to ChatOpenAI?
model_config: {
- model_name
- provider
- temperature
- max_tokens
- model_kwargs
}
temperature and max_tokens can go within parameters if required?
backend/settings.py
Outdated
Comment on lines
28
to
29
| AI_GATEWAY = os.getenv("AI_GATEWAY", "openai") | ||
| AI_GATEWAY_CONFIG = json.loads(os.getenv("AI_GATEWAY_CONFIG", "{}")) |
innoavator
force-pushed
the
model_gateway
branch
from
997ebe0
to
081d677
Compare
innoavator
changed the title
S1LV3RJ1NX
approved these changes
Jun 21, 2024
| if not model_provider_config.api_key_env_var: | ||
| api_key = None | ||
| else: | ||
| api_key = os.environ.get(model_provider_config.api_key_env_var, '') |
There was a problem hiding this comment.
we can use vars from settings.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en models