Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129677 / 24.10 / Remove unnecessary dumping of args #13903

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Qubad786
Copy link
Contributor

Context

We removed websocket logging in 2982c2c but we left out a usage which resulted un us dumping args for method calls and it is no longer required/needed to do that anymore.

@Qubad786 Qubad786 added the jira label Jun 20, 2024
@Qubad786 Qubad786 requested a review from a team June 20, 2024 13:29
@bugclerk bugclerk changed the title Remove unnecessary dumping of args NAS-129677 / 24.10 / Remove unnecessary dumping of args Jun 20, 2024
@bugclerk
Copy link
Contributor

1 similar comment
@bugclerk
Copy link
Contributor

Copy link
Contributor

@anodos325 anodos325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Qubad786 Qubad786 merged commit 8aebaf2 into master Jun 20, 2024
2 of 3 checks passed
@Qubad786 Qubad786 deleted the mrehan/fix-redundant-var branch June 20, 2024 13:35
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants