-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131370 / 25.04 / Fix post mount actions execution on system dataset setup #14567
Conversation
Jira label ignored, branch name already named after an existing ticket. |
Are there any concrete steps we can take to improve our CI for these behaviors? |
Changes like this make me squirm. This can break failover on our HA. Have you run an entire CI run against an HA system? |
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
@anodos325 i'll push a new integration test for this ✅ |
e9663bb
to
4a58935
Compare
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
4a58935
to
c297ce0
Compare
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
c297ce0
to
659c819
Compare
659c819
to
6753351
Compare
This PR has been merged and conversations have been locked. |
Problem
When system dataset is being migrated, if we have a pool from where it i being migrated - we are temporarily mounting it to another location before it is mounted at it's rightful place so we can copy over data.
However during this transition, we have post mount actions being executed which is not alright and can trigger different failures which in the case i ended up finding this was an issue related to netdata setup not being properly executed.
Solution
Ensure all post mount actions only when the system dataset is mounted at it's rightful place i.e
/var/db/system
. Additionally, permissions for ix-state directory in netdata are corrected if any exception occurs on the first time system tries to setup netdata.