Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129166 / None / Fix P2ALIGN overflow in dmu_object_alloc_impl #236

Merged
merged 1 commit into from
May 22, 2024

Conversation

amotin
Copy link
Collaborator

@amotin amotin commented May 22, 2024

This is a subset of much bigger master patch: "Replace P2ALIGN with P2ALIGN_TYPED and delete P2ALIGN.", supposed to fix our specific issue without risking resolving merge conflicts last moment.

@amotin amotin requested a review from ixhamza May 22, 2024 16:24
@bugclerk bugclerk changed the title Fix P2ALIGN overflow in dmu_object_alloc_impl NAS-129166 / None / Fix P2ALIGN overflow in dmu_object_alloc_impl May 22, 2024
@amotin amotin requested a review from usaleem-ix May 22, 2024 16:24
@bugclerk
Copy link

@usaleem-ix
Copy link

Can you please add Signed-Off-by: in the commit message to make checkstyle happy.

This is a subset of much bigger master patch: "Replace P2ALIGN with
P2ALIGN_TYPED and delete P2ALIGN.", supposed to fix our specific
issue without risking resolving merge conflicts last moment.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored-By: iXsystems, Inc.
@amotin
Copy link
Collaborator Author

amotin commented May 22, 2024

Can you please add Signed-Off-by: in the commit message to make checkstyle happy.

I'd say why do we care in our own repo, but whatever. Added.

@amotin amotin merged commit e05da97 into truenas/zfs-2.2-release May 22, 2024
21 of 22 checks passed
@bugclerk
Copy link

Not updating JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129166 target versions as no JIRA version corresponds to this PR

@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 22, 2024
@amotin amotin deleted the NAS-129166 branch May 22, 2024 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants