Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: route installer #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: route installer #71

wants to merge 2 commits into from

Conversation

AMFTech512
Copy link
Contributor

@AMFTech512 AMFTech512 commented Dec 12, 2022

This package enables packages to install their routes into other packages. It has a function and an action that can be invoked during the installation of a package. A common use case for this is if a package has a special admin interface to configure it. It can add itself to the creator's site. To use the function, call it with the following payload:

{
    "runtimeData": {
        "packagePath": "PATH OF PACKAGE WITH ROUTES TO INSTALL"
    }
}

Problems left to solve:

@rileymiller
Copy link
Contributor

I think we should be able to add some sort of flow to truffle-cli where it compares all of the routes on the previous package version to the fs routes and should prompt the user on whether they want to explicitly delete a route, and if so, the route doesn't get ported over. Imagine we'd also be able to add a flag to truffle-cli deploy that specifies some sort of default behavior so that process can be run headless in CI.

@AMFTech512 AMFTech512 force-pushed the master branch 2 times, most recently from 18583de to 7238189 Compare June 16, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants