Fixes #2580 - parse port to number type if provided in a different type #2610

jeffsmale90 · 2022-03-16T02:51:33Z

I didn't end up changing the listen() signature, I agree that having a specific signature makes sense.

I did check the http.server.listen() behaviour, AFAIK our implementation now matches it wrt providing port number as string.

davidmurdoch

Looks great!

I've left some comments requesting some changes. Let me know if you need additional explanations on anything I've suggested here.

src/packages/core/src/server.ts

src/packages/core/tests/server.test.ts

* Improved validation and parsing of port value - inspiration from nodejs internal port validator * Wider range of postive and negative test values, including octal and binary * Fixed spelling of hexadecimal

src/packages/core/src/server.ts

…#2610) * Fixes trufflesuite#2580 * Improved validation and parsing of port value - inspiration from nodejs internal port validator

Fixes #2580 - parse port to number type if provided in a different type

940a16e

jeffsmale90 requested a review from davidmurdoch March 16, 2022 02:51

jeffsmale90 self-assigned this Mar 16, 2022

jeffsmale90 linked an issue Mar 16, 2022 that may be closed by this pull request

Incoherent "Address already in use 127.0.0.1:XXXX" issue when using Ganache programmatically (JS) #2580

Closed

davidmurdoch suggested changes Mar 16, 2022

View reviewed changes

src/packages/core/src/server.ts Outdated Show resolved Hide resolved

src/packages/core/tests/server.test.ts Outdated Show resolved Hide resolved

src/packages/core/tests/server.test.ts Show resolved Hide resolved

Fixes for #2610

e523a37

* Improved validation and parsing of port value - inspiration from nodejs internal port validator * Wider range of postive and negative test values, including octal and binary * Fixed spelling of hexadecimal

jeffsmale90 requested a review from davidmurdoch March 17, 2022 02:55

davidmurdoch reviewed Mar 17, 2022

View reviewed changes

src/packages/core/src/server.ts Outdated Show resolved Hide resolved

fix: #2610 replace string.prototype.trim.apply with string.trim

c5f90bf

davidmurdoch approved these changes Mar 17, 2022

View reviewed changes

jeffsmale90 merged commit 386771d into develop Mar 17, 2022

jeffsmale90 deleted the fix/non-numeric-port-number branch March 17, 2022 21:52

davidmurdoch mentioned this pull request Mar 19, 2022

Support binding to port 0 #2643

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #2580 - parse port to number type if provided in a different type #2610

Fixes #2580 - parse port to number type if provided in a different type #2610

jeffsmale90 commented Mar 16, 2022

davidmurdoch left a comment

Fixes #2580 - parse port to number type if provided in a different type #2610

Fixes #2580 - parse port to number type if provided in a different type #2610

Conversation

jeffsmale90 commented Mar 16, 2022

davidmurdoch left a comment

Choose a reason for hiding this comment