This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update compile and deployment module #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ccowell
commented
Dec 20, 2018
ccowell
commented
- Modularize pretest setup into a helper function
- Added support for multiple contract filenames
- Updated tests dependent on previous compile/deploy module
- abi - accounts - bytecode - contract - instance - provider - sources - web3
- abi - accounts - bytecode - contract - instance - provider - sources - web3 Updated undefined.js to use new pretest setUp module.
…core into compile-and-deploy Updated undefined.js to use compile and deploy module.
Check for file extension when handling contracts
davidmurdoch
suggested changes
Dec 20, 2018
There was a problem hiding this comment.
Looking great so far @ccowell! Have a couple of things I want changed and a few suggestions too. Thanks!
Renamed helper files Fixed broken file paths Simplified some logic
Updated test referencing Example.sol
Parallelized web3 calls when possible
davidmurdoch
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.