This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
importRawKey added #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,6 +101,7 @@ The RPC methods currently implemented are: | |||
| * `personal_listAccounts` | |||
| * `personal_lockAccount` | |||
| * `personal_newAccount` | |||
| * `personal_importRawAccount` | |||
There was a problem hiding this comment.
I think you meant personal_importRawKey here.
There was a problem hiding this comment.
No need for you to correct this - I'll do it on merge.
| @@ -390,6 +390,14 @@ GethApiDouble.prototype.personal_newAccount = function(password, callback) { | |||
| callback(null, account.address); | |||
| }; | |||
|
|
|||
| GethApiDouble.prototype.personal_importRawKey = function(rawKey, password, callback) { | |||
| var account = this.state.createAccount({ secretKey: rawKey }); | |||
There was a problem hiding this comment.
This should probably be updated to make use of options.defaultBalanceEther (see latest README.md in develop branch)
There was a problem hiding this comment.
Actually, scratch that - we likely want this account to be added with a zero balance.
|
Thanks for the contribution, @jbaylina! Merging this one now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for
personal.importRawKey.This is needed when you want to create transactions from a specific account.