This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: return exactly 32 bytes from eth_getStorageAt
#3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
approved these changes
Aug 11, 2022
jeffsmale90
suggested changes
Aug 15, 2022
tenthirtyone
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Agree with @jeffsmale90 about a const for word length somewhere.
By the way, I've made issue #3542 for this so we don't have to hold this up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth_getStorageAtwas returning compact representations of data, e.g.,"0x5"instead of"0x0000000000000000000000000000000000000000000000000000000000000005". We now always return the padded whole 32 byte word.Fixes #3526