Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: properly cast the date in evm_setTime #601

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix: properly cast the date in evm_setTime #601

merged 1 commit into from
Aug 12, 2020

Conversation

Ivshti
Copy link
Contributor

@Ivshti Ivshti commented Aug 1, 2020 •
edited
Loading

Fixes #600

When calling evm_setTime through JSONRPC, this value is a string/number but blockchain.setTime expects it to be a date.

This cannot possibly have side effects since even if a Date is passed in there, new Date(date) will preserve the value

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.527% when pulling 1b23a0b on AdExNetwork:develop into 18f11f7 on trufflesuite:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.527% when pulling 1b23a0b on AdExNetwork:develop into 18f11f7 on trufflesuite:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.527% when pulling 1b23a0b on AdExNetwork:develop into 18f11f7 on trufflesuite:develop.

@Ivshti Ivshti mentioned this pull request Aug 3, 2020
Closed
@davidmurdoch davidmurdoch merged commit e5e8b80 into trufflesuite:develop Aug 12, 2020
nicholasjpaterno
nicholasjpaterno approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@nicholasjpaterno nicholasjpaterno nicholasjpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evm_setTime fails when called through web3.currentProvider.send
4 participants
@Ivshti @coveralls @davidmurdoch @nicholasjpaterno