This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(forking): invalidate _deleted in ForkedStorageTrie if a subsequent put happens
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
davidmurdoch
approved these changes
Aug 18, 2020
davidmurdoch
changed the title
_deleted in ForkedStorageTrie if a subsequent put happens_deleted in ForkedStorageTrie if a subsequent put happens
This was referenced Aug 19, 2020
|
@seesemichaelj thank you so much! |
|
This is great! Any idea when this will get merged into ganache-cli? |
|
@chanhosuh You can try it out now with v6.10.1-beta.2! |
|
@seesemichaelj you're awesome! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #571 by wrapping the
Trie.putmethod inForkedStorageTrie, checking if_deleted.get(rpcKey) === 1, and setting it to0if it is. This PR adds a simple test that gets to the root of the issue:_deletedwas being set for a storage slot 0 when a bool was changed fromtruetofalse, but we never "undelete" it if it's set back totrue. This caused an erroneous error when contracts looked at that boolean again and got0becauseForkedStorageTriedetermined it was set to0(interpreted asfalse) hereTo add a reason for supporting merging #610, those Infura tests gave me a simple, ready to use way to reproduce the error and understand the root cause. From there, I determined I could create a non-Infura reproduction of the error.