This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Ensure not-null binary before adding instance #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryR
reviewed
Jul 4, 2018
|
|
||
| return context; | ||
| return context; |
There was a problem hiding this comment.
Surely you need to return context regardless of if an instance is emitted?
This will break method chaining if it returns null
There was a problem hiding this comment.
I don't think those return values are actually used... I think returning undefined is fine.
gnidan
approved these changes
Jul 5, 2018
|
|
||
| return context; | ||
| return context; |
There was a problem hiding this comment.
I don't think those return values are actually used... I think returning undefined is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #1051
Simple check that ensures binary is not equal to "0x0" before searching for it and adding the instance to an address.