This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
remove require cache invalidation
#5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e - and unused Module import
eggplantzzz
changed the title
require cache invalidation
haltman-at
added
breaking-change: @truffle/config
and removed
requires-breaking-change
labels
|
(I changed the labels on this, the "requires-breaking-change" label is for issues that would require a Truffle breaking change; PRs that break a particular package should be marked with the appropriate label for that package.) |
cds-amal
approved these changes
Dec 12, 2022
| @@ -11,12 +11,9 @@ describe("config", function () { | |||
| let output = ""; | |||
| let memStream; | |||
|
|
|||
| before(function () { | |||
| beforeEach(function () { | |||
There was a problem hiding this comment.
Clearing the cache allowed this to pass before?
There was a problem hiding this comment.
I think so - I think the complications arose from the order in which Config merges in changes in load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE FOR @truffle/config.
So #5728 brought to our attention the fact that this cache invalidation does not work in the bundle (since
requirein this case is webpack's and not Node's). This PR deletes this line of code until we decide that we actually need to invalidate Node's cache.